testapi: Adapt check_screen timeout default to proposal in documentation #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
force-pushed
the
feature/check_screen
branch
from
f492064
to
76b3ac6
Compare
okurz
changed the title
|
@AdamWill WDYT? |
|
we have exactly two occurrences of but, why all the apparently-unrelated changes to doc files and stuff? lint problems? |
The doc string of the method check_screen already suggested to use a timeout of 0 seconds for a long time. This change adjusts the timeout to a default of 0 seconds. This can be considered a breaking change :)
okurz
force-pushed
the
feature/check_screen
branch
from
76b3ac6
to
002b7e2
Compare
okurz
added a commit
to okurz/os-autoinst-distri-opensuse
that referenced
this pull request
May 24, 2018
…nt obvious This also serves as preparation for os-autoinst/os-autoinst#965 which changes the default timeout of check_screen from 30 seconds to 0.
|
hmpf, auto-updated doc-file from tests, bad idea :( Excluded the doc-file, thx |
|
LGTM |
Martchus
approved these changes
May 25, 2018
coolo
changed the title
|
blocked by os-autoinst/os-autoinst-distri-opensuse#5131 |
okurz
added a commit
to okurz/os-autoinst-distri-opensuse
that referenced
this pull request
Jun 8, 2018
…nt obvious This also serves as preparation for os-autoinst/os-autoinst#965 which changes the default timeout of check_screen from 30 seconds to 0.
okurz
added a commit
to okurz/os-autoinst-distri-opensuse
that referenced
this pull request
Jun 24, 2018
…nt obvious This also serves as preparation for os-autoinst/os-autoinst#965 which changes the default timeout of check_screen from 30 seconds to 0.
|
test adaptions have been merged, good to go |
|
hello? |
|
in case anyone was waiting for me: I updated our tests to be OK with this change ages ago, no objection to merging this. |
coolo
approved these changes
Jul 20, 2018
foursixnine
approved these changes
Jul 21, 2018
|
I forgot to remove the notready label :) |
okurz
added a commit
to okurz/os-autoinst-distri-opensuse
that referenced
this pull request
Jul 25, 2018
Provide a sane non-zero timeout for the "check_screen" call in "init_desktop_runner" which is used in "x11_start_program" as after os-autoinst/os-autoinst#965 the command "check_screen" has a default timeout of 0 seconds and not 30 anymore. Related progress issue: https://progress.opensuse.org/issues/38837
okurz
added a commit
to okurz/os-autoinst-distri-opensuse
that referenced
this pull request
Jul 25, 2018
Provide a sane non-zero timeout for the "check_screen" call in "init_desktop_runner" which is used in "x11_start_program" as after os-autoinst/os-autoinst#965 the command "check_screen" has a default timeout of 0 seconds and not 30 anymore. Related progress issue: https://progress.opensuse.org/issues/38837
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc string of the method check_screen already suggested to use a timeout
of 0 seconds for a long time. This change adjusts the timeout to a default of
0 seconds. This can be considered a breaking change :)